Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firefox keycodes for '=' and '-'. #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aroonav
Copy link

@aroonav aroonav commented May 15, 2018

This should resolve issues referenced in pull request #215 (#215).
The above pull request can't be merged as of now. This will be useful to resolve bugs downstream.

@aroonav
Copy link
Author

aroonav commented May 15, 2018

I would like to add that the keycode 173 is being used by Opera, IE, Chrome & Safari for the Mute On/Off button. (Source: http://www.javascripter.net/faq/keycodes.htm)
Will this be an issue? If yes, what can be done about it??

@aroonav
Copy link
Author

aroonav commented May 16, 2018

I have added a check which will only add the keycode for '-' if it is on the Firefox browser.
I have removed the FF's keycode for '=' as it is working correctly. For some reason unknown to me, Ctrl+=, Ctrl+; have consistent behavior in all browsers except Firefox.

Only Ctrl+- didn't work properly in FF which this PR should take care of.

@JackyTung
Copy link

can this PR be merged? I need this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants